]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
screencast: Fix disabling screencasts via session mode
authorFlorian Müllner <fmuellner@gnome.org>
Mon, 4 Nov 2013 13:06:33 +0000 (14:06 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Mon, 4 Nov 2013 15:21:45 +0000 (16:21 +0100)
If screencasts are disabled, we return a DBus error, but still start
the recording happily - add early returns in that case.

https://bugzilla.gnome.org/show_bug.cgi?id=699752

js/ui/screencast.js

index a1593b2544d6bc882c2325f4709defa7332ca8d4..23d6a42690c466f9176e3911d33abfd9d0d908fb 100644 (file)
@@ -105,8 +105,10 @@ const ScreencastService = new Lang.Class({
 
     ScreencastAsync: function(params, invocation) {
         let returnValue = [false, ''];
-        if (!Main.sessionMode.allowScreencast)
+        if (!Main.sessionMode.allowScreencast) {
             invocation.return_value(GLib.Variant.new('(bs)', returnValue));
+            return;
+        }
 
         let sender = invocation.get_sender();
         let recorder = this._ensureRecorderForSender(sender);
@@ -124,8 +126,10 @@ const ScreencastService = new Lang.Class({
 
     ScreencastAreaAsync: function(params, invocation) {
         let returnValue = [false, ''];
-        if (!Main.sessionMode.allowScreencast)
+        if (!Main.sessionMode.allowScreencast) {
             invocation.return_value(GLib.Variant.new('(bs)', returnValue));
+            return;
+        }
 
         let sender = invocation.get_sender();
         let recorder = this._ensureRecorderForSender(sender);